Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo corrected Acstract -> Abstract #20058

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Typo corrected Acstract -> Abstract #20058

merged 2 commits into from
Jan 16, 2019

Conversation

Eayshwary
Copy link
Contributor

@Eayshwary Eayshwary commented Jan 3, 2019 •
edited
Loading

Description (*)

Typo corrected Acstract -> Abstract

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 3, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @Eayshwary. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil nuzil self-requested a review January 3, 2019 15:03
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3783 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Eayshwary thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 85607c8 into magento:2.3-develop Jan 16, 2019
@ghost
Copy link

ghost commented Jan 16, 2019

Hi @Eayshwary, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 16, 2019
@sivaschenko
ENGCOM-3783: Typo corrected Acstract -> Abstract #20058
11801e2
@magento-engcom-team
Copy link
Contributor

Hi @Eayshwary. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@mageprince mageprince mentioned this pull request Jan 23, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil nuzil approved these changes

Assignees

@nuzil nuzil

Labels
Area: Frontend Cleanup Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Eayshwary @magento-cicd2 @magento-engcom-team @nuzil @p-bystritsky